So sorry, completely forgot about formatting.
Here is the 'before' code from my first post.
public List filterListOfIntegersToPositives(List original, boolean inclZero) {
List ret = new ArrayList(original.size());
if (inclZero) {
// code that does filtering
for(int i=0; i<original.size(); i++){
Integer thisInt = (Integer) original.get(i);
if (thisInt.compareTo(Integer.valueOf("0")) > -1) {
ret.add(thisInt);
}
}
// end code that does filtering
} else {
// code that does filtering
for(int i=0; i<original.size(); i++){
Integer thisInt = (Integer) original.get(i);
if (thisInt.compareTo(Integer.valueOf("0")) > 0) {
ret.add(thisInt);
}
}
// end code that does filtering
}
return ret;
}
And here is the code after you've refactored using a ternary operator...
public List filterListOfIntegersToPositives(List original, boolean inclZero) {
List ret = new ArrayList(original.size());
// code that does filtering
for(int i=0; i<original.size(); i++){
Integer thisInt = (Integer) original.get(i);
if (thisInt.compareTo(Integer.valueOf("0")) > (inclZero ? -1 : 0)) {
ret.add(thisInt);
}
}
// end code that does filtering
return ret;
}
Apologies for the mistake before - why is there no Preview post in this forum??? |
java.net RSS Feeds
